piotr-szuberski commented on a change in pull request #13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r546371853
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProvider.java
##########
@@ -85,6 +89,33 @@ public BeamSqlTable buildBeamSqlTable(Table table) {
} catch (ClassNotFoundException e) {
throw new IllegalArgumentException("Incorrect proto class provided:
" + protoClassName);
}
+ case THRIFT:
+ final String thriftClassName = properties.getString("thriftClass");
Review comment:
I agree that at least PROTO case should be delegated to a method as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
