ibzib commented on pull request #13597:
URL: https://github.com/apache/beam/pull/13597#issuecomment-750423282


   > I don't think this will fix the issue since even if the sdk.properties is 
regenerated, it will be ignored for the purposes of that test.
   
   Yeah, you're right. But at least the updated sdk.properties will be included 
in jars if they're rebuilt for some other reason.
   
   > What we need to do is ignore only the timestamp in the sdk.properties file.
   
   Or we could just remove the timestamp? I don't think it's used anywhere. The 
only place that reads from sdk.properties is 
[ReleaseInfo.java](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java),
 and it doesn't seem to read the timestamp at all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to