ibzib commented on a change in pull request #12938:
URL: https://github.com/apache/beam/pull/12938#discussion_r550304725
##########
File path: runners/flink/1.8/build.gradle
##########
@@ -17,7 +17,6 @@
*/
def basePath = '..'
-
Review comment:
Please revert this change.
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -40,13 +40,13 @@ applyJavaNature(
// In the case of the Fn API worker jar we are creating an application so
we rely on
// the shadow plugin to include all transitive dependencies to create an
uber jar.
- // Include original source files extracted under
- // '$buildDir/original_sources_to_package' to jar
- from "$buildDir/original_sources_to_package"
+ // Include original source files extracted under
Review comment:
Please revert these indentation changes.
##########
File path: sdks/java/testing/kafka-service/build.gradle
##########
@@ -13,7 +13,7 @@
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
- * limitations under the License.
+ * limitations under the License.dependencies
Review comment:
Please revert this change.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
Review comment:
Don't add jsr305 as a compile dependency; it should be a compileOnly
dependency. Also, since the transitive dependency on jsr305 is introduced by
`spotBugs`, jsr305 should be included in `compileOnlyAnnotationDeps`. Including
jsr305 in `compileOnlyAnnotationDeps` will remove the need to add it in every
build file.
##########
File path: runners/flink/job-server/flink_job_server.gradle
##########
@@ -94,6 +94,7 @@ dependencies {
runtimeOnly project(":sdks:java:io:google-cloud-platform")
// SqlTransform
runtimeOnly project(":sdks:java:extensions:sql:expansion-service")
+ permitUnusedDeclared project(":runners:flink:1.8")
Review comment:
Didn't you already do this in
`runners/flink/1.8/job-server/build.gradle`?
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
Review comment:
You will need to exclude Zookeeper from kafka-avro-serializer like we do
for other Kafka dependencies in `sdks/java/io/kafka/build.gradle`.
##########
File path: runners/flink/1.10/job-server/build.gradle
##########
@@ -29,3 +29,7 @@ project.ext {
// Load the main build script which contains all build logic.
apply from: "$basePath/flink_job_server.gradle"
+
+dependencies {
+ permitUnusedDeclared project(":runners:flink:1.10")
Review comment:
Can you add a comment explaining that?
##########
File path: sdks/java/javadoc/build.gradle
##########
@@ -84,3 +84,4 @@ task aggregateJavadoc(type: Javadoc) {
}
}
}
+
Review comment:
Please revert this change.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
+ compile library.java.vendored_grpc_1_26_0
+ compile "com.github.spotbugs:spotbugs-annotations:3.1.9"
Review comment:
Spotbugs has an LGPL license, so it's not allowed to be included in Beam
as a compile dependency. Remove it.
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,15 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile library.java.jsr305
+ compile "io.confluent:kafka-avro-serializer:5.3.2"
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile "com.google.oauth-client:google-oauth-client:1.31.0"
Review comment:
Use `library.java.google_oauth_client` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
