iemejia commented on a change in pull request #13619:
URL: https://github.com/apache/beam/pull/13619#discussion_r550488704
##########
File path:
sdks/java/io/parquet/src/test/java/org/apache/beam/sdk/io/parquet/ParquetIOTest.java
##########
@@ -147,7 +147,7 @@ public void testBlockTracker() throws Exception {
public void testSplitBlockWithLimit() {
ParquetIO.ReadFiles.SplitReadFn<GenericRecord> testFn =
new ParquetIO.ReadFiles.SplitReadFn<>(
- null, null, ParquetIO.GenericRecordPassthroughFn.create());
+ null, null, ParquetIO.GenericRecordPassthroughFn.create(), null);
Review comment:
I would prefer it to not be Nullable but since this is internal I
suppose we can adjust this later, on the other hand if someday Parquet finally
gets rid of its Hadoop dependencies probably the null value would align better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
