tysonjh commented on a change in pull request #13669:
URL: https://github.com/apache/beam/pull/13669#discussion_r558474683
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
This is a lower version than `$checkerframework_version`, is there a
reason?
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
Review comment:
Move this up with the other `library.` definitions.
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
+ compile "org.twister2:comms-api-java:0.6.0"
Review comment:
Use `$twister2_version` throughout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
