ibzib commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r561156821



##########
File path: runners/flink/flink_runner.gradle
##########
@@ -137,11 +138,9 @@ dependencies {
   compile project(":runners:java-job-service")
   compile project(":sdks:java:extensions:google-cloud-platform-core")
   compile library.java.vendored_grpc_1_26_0
-  compile library.java.jackson_annotations
   compile library.java.slf4j_api
   compile library.java.joda_time
   compile library.java.args4j
-  compile "org.apache.flink:flink-clients_2.11:$flink_version"

Review comment:
       The precommit is catching a legitimate error. I think flink-clients 
needs to be on the runtime classpath in order to provide Flink local mode. Try 
making flink-clients `runtimeOnly`.
   
   ```
   org.apache.beam.sdk.Pipeline$PipelineExecutionException: 
java.lang.IllegalStateException: No ExecutorFactory found to execute the 
application.
        at 
org.apache.beam.runners.flink.TestFlinkRunner.run(TestFlinkRunner.java:75)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to