ibzib commented on a change in pull request #13667:
URL: https://github.com/apache/beam/pull/13667#discussion_r562122107
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,22 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
- compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
- compile "org.scala-lang:scala-library:2.11.8"
+ runtimeOnly "org.rocksdb:rocksdbjni:5.7.3"
+ runtimeOnly "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
- compile "org.apache.samza:samza-kafka_2.11:$samza_version"
- compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ runtimeOnly "org.apache.samza:samza-kafka_2.11:$samza_version"
+ runtimeOnly "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
compile "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version"
compile "org.apache.samza:samza-kv-inmemory_2.11:$samza_version"
compile "org.apache.samza:samza-yarn_2.11:$samza_version"
- compile "org.apache.kafka:kafka-clients:0.11.0.2"
+ runtimeOnly "org.apache.kafka:kafka-clients:0.11.0.2"
+ //permitUnusedDeclared "org.apache.kafka:kafka-clients:2.4.1"
Review comment:
```suggestion
```
##########
File path: runners/samza/build.gradle
##########
@@ -53,21 +54,21 @@ dependencies {
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.commons_io
- compile library.java.commons_lang3
- compile library.java.args4j
- compile "javax.servlet:javax.servlet-api:3.1.0"
- compile "io.dropwizard.metrics:metrics-core:3.1.2"
- compile "org.rocksdb:rocksdbjni:5.7.3"
- compile "org.apache.commons:commons-collections4:4.0"
- compile "org.scala-lang:scala-library:2.11.8"
+ runtimeOnly "org.rocksdb:rocksdbjni:5.7.3"
+ runtimeOnly "org.scala-lang:scala-library:2.11.8"
compile "org.apache.samza:samza-api:$samza_version"
compile "org.apache.samza:samza-core_2.11:$samza_version"
- compile "org.apache.samza:samza-kafka_2.11:$samza_version"
- compile "org.apache.samza:samza-kv_2.11:$samza_version"
+ runtimeOnly "org.apache.samza:samza-kafka_2.11:$samza_version"
+ runtimeOnly "org.apache.samza:samza-kv_2.11:$samza_version"
+ compile project(":sdks:java:expansion-service")
compile "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version"
compile "org.apache.samza:samza-kv-inmemory_2.11:$samza_version"
compile "org.apache.samza:samza-yarn_2.11:$samza_version"
- compile "org.apache.kafka:kafka-clients:0.11.0.2"
+ runtimeOnly "org.apache.kafka:kafka-clients:0.11.0.2"
+ compile library.java.vendored_grpc_1_26_0
+ compile project(path: ":model:job-management:", configuration: "shadow")
Review comment:
Remove stray colon.
```suggestion
compile project(path: ":model:job-management", configuration: "shadow")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
