ibzib commented on a change in pull request #13656:
URL: https://github.com/apache/beam/pull/13656#discussion_r562927667
##########
File path: runners/direct-java/build.gradle
##########
@@ -93,6 +89,10 @@ dependencies {
validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
validatesRunner project(path: project.path, configuration: "shadow")
validatesRunner project(path: project.path, configuration: "shadowTest")
+ //runtime dependencies of the tests
+ permitUnusedDeclared library.java.vendored_grpc_1_26_0
+ permitUnusedDeclared project(":runners:java-fn-execution")
+ permitUnusedDeclared project(":sdks:java:fn-execution")
Review comment:
Oops, shadowTest still puts things on the compile classpath. So maybe
`testRuntimeOnly` is the correct configuration. Anyway, it doesn't need to
block this PR since there's no regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
