TheNeuralBit commented on a change in pull request #13565:
URL: https://github.com/apache/beam/pull/13565#discussion_r570456145
##########
File path: website/www/site/content/en/contribute/_index.md
##########
@@ -21,55 +24,61 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-# Apache Beam Contribution Guide
+# Contribution guide
+
+<a class="arrow-list-header" data-toggle="collapse" href="#collapseOverview"
role="button" aria-expanded="false" aria-controls="collapseOverview">
+ {{< figure src="/images/arrow-icon_list.svg">}}
Review comment:
Ok the dropdown buttons work better on desktop now. They still seem
broken on mobile though, nothing happens when I click them.
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -0,0 +1,42 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy
of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+$(document).ready(function() {
+ function copy() {
+ $(".copy").click(function(){
+ var
text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ const el=document.createElement('textarea');
+ el.value=text;document.body.appendChild(el);
+ el.select();document.execCommand('copy');
+ document.body.removeChild(el);
+ alert('copied to clipboard');
+ })
+ $(".just-copy").click(function(){
+ var text=$(this).parent().siblings()[0].innerHTML;
+ const el=document.createElement('textarea');
+ el.value=text;document.body.appendChild(el);
+ el.select();document.execCommand('copy');
+ document.body.removeChild(el);
+ alert('copied to clipboard');
Review comment:
This alert is strange to me. It's weird to have to click "OK" after
copying.
Other implementations of this usually pop up a notification to let you know
the content has been copied, but you don't have to acknowledge it. If it's too
much to address this right now let's file a jira about it.
##########
File path: website/www/site/data/en/committer_traits.yaml
##########
@@ -0,0 +1,21 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- body: { text: To learn more see the ASF documentation., link:
https://www.apache.org/foundation/policies/conduct.html }
+ bolded: Knows, upholds, and reinforces the Apache Software Foundation code
of conduct.
+ icon: icons/contributor/become a committer/messages-icon.svg
+- body: { text: To learn more see the ASF documentation., link:
https://infra.apache.org/committers.html#committer-responsibilities }
+ bolded: Knows, upholds, and reinforces the responsibilities of an Apache
Software Foundation committer.
+ icon: icons/contributor/become a committer/beam-logo-icon.svg
+- body: { text: To learn more see our best practices!, link:
https://beam.apache.org/contribute/become-a-committer/ }
Review comment:
become-a-committer is the page that this is displayed on. I think this
link should be /attributes/?
This seems a little backwards again.. but that is a design question for
@griscz
##########
File path: website/www/site/content/en/contribute/_index.md
##########
@@ -21,55 +24,61 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
-# Apache Beam Contribution Guide
+# Contribution guide
+
+<a class="arrow-list-header" data-toggle="collapse" href="#collapseOverview"
role="button" aria-expanded="false" aria-controls="collapseOverview">
+ {{< figure src="/images/arrow-icon_list.svg">}}
+
+## Overview
+
+</a>
+
+<div class="collapse dont-collapse-sm" id="collapseOverview">
-The Apache Beam community welcomes contributions from anyone!
+There are lots of opportunities to contribute. You can for example:
-If you have questions, please [reach out to the Beam
community](/contribute/get-help).
+* ask or answer questions on [[email protected]](/community/contact-us/) or
+ [stackoverflow](https://stackoverflow.com/questions/tagged/apache-beam)
+* review proposed design ideas on
[[email protected]](/community/contact-us/)
+* file [bug reports](https://issues.apache.org/jira/projects/BEAM/issues)
+* review [changes](https://github.com/apache/beam/pulls)
+* work on the core programming model (what is a Beam pipeline and how does it
+ run?)
+* improve the developer experience (for example, Windows guides)
+* organize local meetups of users or contributors to Apache Beam
-There are lots of opportunities to contribute:
+...and many more. Most importantly, if you have an idea of how to contribute,
then do it!
Review comment:
This is still not rendering correctly, I think we should just remove the
"... and many more" unless you know what's going wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
