ramazan-yapparov commented on pull request #13948:
URL: https://github.com/apache/beam/pull/13948#issuecomment-777237755


   > LGTM, thank you!
   > 
   > > I can move the libraries map from Groovy module to Kotlin file in 
buildSrc project and change is from being a Map to object
   > > That way we will be able to access that object without this ugly casts 
and use object fields access instead of some "magic string"
   > 
   > Are you saying you can do this once BeamModulePlugin.groovy has been 
converted? If so please add a TODO to remind us to follow up with that
   
   No, I can do it now - move only `libraries` and leave the rest as is


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to