apilloud commented on a change in pull request #13898:
URL: https://github.com/apache/beam/pull/13898#discussion_r577298112
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -129,20 +149,61 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x)
{
for (RexNode rexNode : logicalCalc.getProgram().getExprList()) {
if (rexNode instanceof RexCall) {
RexCall call = (RexCall) rexNode;
- if (call.getOperator() instanceof SqlUserDefinedFunction) {
+ final SqlOperator operator = call.getOperator();
+
+ CallImplementor implementor = RexImpTable.INSTANCE.get(operator);
+ if (implementor == null) {
+ // Reject methods with no implimentation
+ return false;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
