boyuanzz commented on pull request #14013: URL: https://github.com/apache/beam/pull/14013#issuecomment-781576773
Hi Jan, From your changes it seems like you want to have `EmptyUnboundedSource.EmptyUnboundedReader` reports last watermark instead of `BoundedWindow.TIMESTAMP_MAX_VALUE`. But it's intended to have `EmptyUnboundedSource.EmptyUnboundedReader` to report `BoundedWindow.TIMESTAMP_MAX_VALUE` as watermark to mark current restriction has finished processing and should not hold watermark back. I checked discussion thread: https://lists.apache.org/thread.html/r3873ed7e3927c6fc81f6793af779e28cea9bc8f674ec89a7709bde31%40%3Cuser.beam.apache.org%3E and in your last comment you are saying that `The problem is that under heavy load (i.e. when the UnboundedReader reads data without ever returning false in response to advance()) the watermark is not progressed correctly.`. Would you like to elaborate more on the relationship between this comment and this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
