pabloem commented on a change in pull request #14026:
URL: https://github.com/apache/beam/pull/14026#discussion_r581202375
##########
File path: release/src/main/groovy/mobilegaming-java-dataflow.groovy
##########
@@ -110,7 +110,14 @@ class LeaderBoardRunner {
}
InjectorThread.stop()
LeaderBoardThread.stop()
- t.run("gcloud dataflow jobs cancel \$(gcloud dataflow jobs list | grep
${jobName} | grep Running | cut -d' ' -f1)")
+ t.run("""RUNNING_JOB=`gcloud dataflow jobs list | grep ${jobName} | grep
Running | cut -d' ' -f1`
+if [ ! -z "\${RUNNING_JOB}" ]
+ then
+ gcloud dataflow jobs cancel \${RUNNING_JOB}
+ else
+ echo "Job '${jobName}' is not running."
+fi
+""")
Review comment:
does it make sense to retry? are jobs here usually finished/cancelled,
or pending?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
