ibzib commented on a change in pull request #14048:
URL: https://github.com/apache/beam/pull/14048#discussion_r581565945
##########
File path: sdks/java/io/bigquery-io-perf-tests/build.gradle
##########
@@ -17,15 +17,15 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false, publish: false)
+applyJavaNature(enableStrictDependencies:true,exportJavadoc: false, publish:
false)
Review comment:
Nit: spacing
```suggestion
applyJavaNature(enableStrictDependencies: true ,exportJavadoc: false,
publish: false)
```
##########
File path: sdks/java/io/bigquery-io-perf-tests/build.gradle
##########
@@ -17,15 +17,15 @@
*/
plugins { id 'org.apache.beam.module' }
-applyJavaNature(exportJavadoc: false, publish: false)
+applyJavaNature(enableStrictDependencies:true,exportJavadoc: false, publish:
false)
provideIntegrationTestingDependencies()
enableJavaPerformanceTesting()
description = "Apache Beam :: SDKs :: Java :: Google BigQuery IO Performance
tests"
ext.summary = "Performance tests for Google BigQuery IO sources and sinks"
dependencies {
- compile library.java.google_api_services_bigquery
+ testImplementation library.java.google_api_services_bigquery
Review comment:
As far as I know, there's not a significant difference between using
testImplementation and testCompile, so let's make this testCompile to match all
the other dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
