chamikaramj commented on a change in pull request #14123:
URL: https://github.com/apache/beam/pull/14123#discussion_r585186041
##########
File path: release/src/main/scripts/publish_docker_images.sh
##########
@@ -39,25 +39,24 @@ RC_VERSION="rc${RC_NUM}"
echo "================Confirming Release and RC version==========="
echo "We are using ${RC_VERSION} to push docker images for ${RELEASE}."
+echo "Publishing the following images:"
+docker images --filter "reference=apache/beam_*:${RELEASE}_${RC_VERSION}"
--format "{{.Repository}}" | while read IMAGE; do
+ echo "${IMAGE}"
+done
echo "Do you want to proceed? [y|N]"
read confirmation
if [[ $confirmation = "y" ]]; then
-
- IMAGES=$(docker images --filter
"reference=apache/beam_*:${RELEASE}_${RC_VERSION}" --format "{{.Repository}}")
- echo "Publishing the following images:" "${IMAGES[@]}"
- echo "Make sure the images are correct, then press any key to proceed."
- read
- for IMAGE in "${IMAGES[@]}"; do
+ docker images --filter "reference=apache/beam_*:${RELEASE}_${RC_VERSION}"
--format "{{.Repository}}" | while read IMAGE; do
Review comment:
Can "reference=apache/beam_*:${RELEASE}_${RC_VERSION}" --format
"{{.Repository}}" part be moved to a variable to maintain consistency ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
