robertwb commented on a change in pull request #14060:
URL: https://github.com/apache/beam/pull/14060#discussion_r595644612
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -2364,6 +2364,22 @@ def from_runner_api_parameter(
def runner_api_requires_keyed_input(self):
return True
+ def get_windowing(self, inputs):
+ # Circular dep, because trigger pulls in CombineFn
+ from apache_beam.transforms.trigger import AfterProcessingTime
Review comment:
This doesn't seem to handle more complex triggers, such as
`AfterWatermark(early=AfterProcessingTime())`. How is that handled in Java?
Alternatively, we could add continuation_windowing which would call
continuation_trigger and we wouldn't have to special case this knowledge in
GBK. (If we're moving away from the idea of continuation triggers in general,
maybe that's not preferable.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
