macksclark commented on pull request #14233: URL: https://github.com/apache/beam/pull/14233#issuecomment-801177858
Can we hold off on merging this? I got some internal feedback that maybe we should change the counter names like: import_success_count -> import_resource_success_count Or something similar, because import_success_count could easily indicate the entire import succeeded, which is not what we are trying to track with these counters. Please let me know if you have an opinion on this naming convention. Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
