ibzib commented on pull request #14392: URL: https://github.com/apache/beam/pull/14392#issuecomment-812754420
I ran compliance tests on this, and some aggregate function tests are failing. For example, one such test expects an error. It was listed as `ALLOW_ERROR` before, and was giving this error: ``` java.lang.AssertionError: type mismatch: aggCall type: BIGINT NOT NULL inferred type: BIGINT ``` But now it does not throw any error, and instead returns a result, which is incorrect. So in summary, this PR fixes one problem, which reveals several other unrelated problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
