kennknowles commented on a change in pull request #14500:
URL: https://github.com/apache/beam/pull/14500#discussion_r610931713
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -191,6 +193,10 @@ private String getApplicationName(AppliedPTransform<?, ?,
?> appliedPTransform)
if (name.isEmpty()) {
name = "unnamed-ptransform";
}
+ // Normalize, trim, and uniqify.
+ int maxNameLength = 100;
+ name = Normalizer.normalize(name, Form.NFC).replaceAll("[^A-Za-z0-9-_]",
"-");
Review comment:
Let's document the required regex in the pipeline proto. Is there
validation logic like there is in Python? That would be a good place to check
it, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
