kennknowles commented on a change in pull request #14373:
URL: https://github.com/apache/beam/pull/14373#discussion_r612640576
##########
File path: sdks/java/testing/tpcds/build.gradle
##########
@@ -16,38 +16,106 @@
* limitations under the License.
*/
-plugins {
- id 'java'
-}
+plugins { id 'org.apache.beam.module' }
+applyJavaNature(
+ automaticModuleName: 'org.apache.beam.sdk.tpcds',
+ exportJavadoc: false,
+ archivesBaseName: 'beam-sdks-java-tpcds',
+)
-description = "Apache Beam :: SDKs :: Java :: TPC-DS Benchark"
+description = "Apache Beam :: SDKs :: Java :: TPC-DS"
-version '2.24.0-SNAPSHOT'
+// When running via Gradle, this property can be used to pass commandline
arguments
+// to the TPD-DS run
+def tpcdsArgsProperty = "tpcds.args"
-sourceCompatibility = 1.8
+// When running via Gradle, this property sets the runner dependency
+def tpcdsRunnerProperty = "tpcds.runner"
+def tpcdsRunnerDependency = project.findProperty(tpcdsRunnerProperty)
+ ?: ":runners:direct-java"
+def shouldProvideSpark = ":runners:spark:2".equals(tpcdsRunnerDependency)
+def isDataflowRunner =
":runners:google-cloud-dataflow-java".equals(tpcdsRunnerDependency)
+def runnerConfiguration = ":runners:direct-java".equals(tpcdsRunnerDependency)
? "shadow" : null
+
+if (isDataflowRunner) {
Review comment:
It is a standard benchmark suite. Yes, it makes sense to run on
runner_v2 (and any other runner configuration someone is interested in)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
