tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r614283145
##########
File path: sdks/python/apache_beam/transforms/environments.py
##########
@@ -337,18 +399,21 @@ def __init__(
env=None, # type: Optional[Mapping[str, str]]
capabilities=(), # type: Iterable[str]
artifacts=(), # type: Iterable[beam_runner_api_pb2.ArtifactInformation]
+ resource_hints=None, # type: Optional[Mapping[str, bytes]]
):
# type: (...) -> None
- super(ProcessEnvironment, self).__init__(capabilities, artifacts)
+ super(ProcessEnvironment,
+ self).__init__(capabilities, artifacts, resource_hints)
self.command = command
self.os = os
self.arch = arch
self.env = env or {}
def __eq__(self, other):
- return self.__class__ == other.__class__ \
- and self.command == other.command and self.os == other.os \
- and self.arch == other.arch and self.env == other.env
+ return (
+ super().__eq__(other) and self.command == other.command and
Review comment:
+1 to consider this out of scope for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
