scwhittle commented on a change in pull request #14617:
URL: https://github.com/apache/beam/pull/14617#discussion_r618987040
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/stream/DirectStreamObserver.java
##########
@@ -59,9 +60,8 @@ public DirectStreamObserver(Phaser phaser,
CallStreamObserver<T> outboundObserve
@Override
public void onNext(T value) {
Review comment:
Yes, I saw Luke mention on some other thread these observers are
supposed to be threadsafe. An example is the BeamFnControlClient which calls
this from different threads on the executor. And this class is marked
@Threadsafe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
