iemejia commented on a change in pull request #14636:
URL: https://github.com/apache/beam/pull/14636#discussion_r620105637
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkCombineFn.java
##########
@@ -722,6 +722,8 @@ public PipelineOptions getPipelineOptions() {
WindowedAccumulator.create(this, toValue, windowingStrategy,
windowComparator);
accumulator.add(value, this);
return accumulator;
+ } catch (RuntimeException ex) {
+ throw ex;
Review comment:
This is exactly what fixes `ViewTest.testNonSingletonSideInput`. Some
internal runners-core stuff throw `RuntimeException`s like
`IllegalArgumentException` and the tests expect those, so we should not be re
wrapping those in a different kind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
