rohdesamuel commented on a change in pull request #14569:
URL: https://github.com/apache/beam/pull/14569#discussion_r623402376
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1640,17 +1669,25 @@ def mode(self, axis=0, *args, **kwargs):
'mode',
lambda df: df.mode(*args, **kwargs),
[self._expr],
- #TODO(robertwb): Approximate?
- requires_partition_by=partitionings.Singleton(),
+ #TODO(BEAM-12181): Can we add an approximate implementation?
+ requires_partition_by=partitionings.Singleton(reason=(
+ "mode(axis='index') cannot currently be parallelized. See "
+ "BEAM-12181 tracking the possble addition of an approximate, "
+ "parallizable implementation of mode."
Review comment:
s/parallizable/parallelizable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
