dpcollins-google commented on a change in pull request #14720:
URL: https://github.com/apache/beam/pull/14720#discussion_r628666969



##########
File path: 
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ReshuffleTest.java
##########
@@ -274,4 +277,26 @@ public void testReshuffleWithTimestampsStreaming() {
 
     pipeline.run();
   }
+
+  @Test
+  @Category({ValidatesRunner.class, UsesTestStream.class})
+  public void testAssignShardFn() {
+
+    PCollection<KV<String, Integer>> input =
+        pipeline
+            .apply(
+                Create.of(ARBITRARY_KVS)
+                    .withCoder(KvCoder.of(StringUtf8Coder.of(), 
VarIntCoder.of())))
+            .apply(Window.into(new GlobalWindows()));

Review comment:
       LGTM. This appears to be deterministic as far as I can tell.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to