TheNeuralBit commented on a change in pull request #13073:
URL: https://github.com/apache/beam/pull/13073#discussion_r629677808
##########
File path: sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/build.gradle
##########
@@ -32,15 +32,14 @@ test {
systemProperty "tests.security.manager", "false"
}
-def log4j_version = "2.6.2"
def elastic_search_version = "5.6.3"
configurations.all {
resolutionStrategy {
// Make sure the log4j versions for api and core match instead of taking
the default
// Gradle rule of using the latest.
- force "org.apache.logging.log4j:log4j-api:$log4j_version"
- force "org.apache.logging.log4j:log4j-core:$log4j_version"
+ force library.java.log4j_api
+ force library.java.log4j_core
Review comment:
I think this is no longer necessary with the change to `library` in
`BeamModulePlugin.groovy`. `applyJavaNature` does this for all dependencies in
`library`:
https://github.com/apache/beam/blob/3c9807bfb4e00a8f8564b4688e01ad5c8c2189d2/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1537-L1544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
