amaliujia commented on a change in pull request #14774:
URL: https://github.com/apache/beam/pull/14774#discussion_r632061480
##########
File path: .test-infra/jenkins/NexmarkBuilder.groovy
##########
@@ -81,16 +87,46 @@ class NexmarkBuilder {
}
- static void suite(context, String title, Runner runner, SDK sdk, Map<String,
Object> options) {
+ static void suite(context, String title, Runner runner, SDK sdk, Map<String,
Object> options, List<String> jobSpecificSwitches, String javaRuntimeVersion) {
+ if (javaRuntimeVersion == JAVA_11_RUNTIME_VERSION) {
+ java11Suite(context, title, runner, sdk, options, jobSpecificSwitches)
+ } else {
+ InfluxDBCredentialsHelper.useCredentials(context)
Review comment:
create a `java8suite` and move this block into that suite.
##########
File path: .test-infra/jenkins/NexmarkBuilder.groovy
##########
@@ -81,16 +87,46 @@ class NexmarkBuilder {
}
- static void suite(context, String title, Runner runner, SDK sdk, Map<String,
Object> options) {
+ static void suite(context, String title, Runner runner, SDK sdk, Map<String,
Object> options, List<String> jobSpecificSwitches, String javaRuntimeVersion) {
+ if (javaRuntimeVersion == JAVA_11_RUNTIME_VERSION) {
+ java11Suite(context, title, runner, sdk, options, jobSpecificSwitches)
+ } else {
+ InfluxDBCredentialsHelper.useCredentials(context)
Review comment:
create a `java8suite` and move this block into that suite?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
