kennknowles commented on a change in pull request #14833:
URL: https://github.com/apache/beam/pull/14833#discussion_r635504461
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/logging/BeamFnLoggingServiceTest.java
##########
@@ -141,13 +144,16 @@ public void
testMultipleClientsFailingIsHandledGracefullyByServer() throws Excep
.withOnError(waitForTermination::countDown)
.build());
outboundObserver.onNext(createLogsWithIds(instructionId,
-instructionId));
- outboundObserver.onError(new RuntimeException("Client " +
instructionId));
- waitForTermination.await();
+ outboundObservers.add(outboundObserver);
return null;
});
}
ExecutorService executorService = Executors.newCachedThreadPool();
executorService.invokeAll(tasks);
+ for (int i = 1; i <= 3; ++i) {
+ outboundObservers.take().onError(new RuntimeException("Client " + i));
Review comment:
AFAICT this way of writing the test more clearly reads what it is
supposed to do anyhow. This change LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
