robertwb commented on a change in pull request #14848:
URL: https://github.com/apache/beam/pull/14848#discussion_r637096598
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -91,10 +94,8 @@
if False: # pylint: disable=using-constant-test
# This clause is interpreted by the compiler.
- from cython import compiled as is_compiled
- else:
- is_compiled = False
- fits_in_64_bits = lambda x: -(1 << 63) <= x <= (1 << 63) - 1
+ from cython import compiled as _is_compiled
+ is_compiled = _is_compiled
Review comment:
I don't think this line would ever get executed. Instead, we may need to
try the import and catch an import error. (We do want this bit to be set to
True when it is compiled.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
