zhoufek commented on a change in pull request #15003: URL: https://github.com/apache/beam/pull/15003#discussion_r652113733
########## File path: CHANGES.md ########## @@ -103,10 +103,13 @@ it was ignored if provided. * `TopCombineFn` disallow `compare` as its argument (Python) ([BEAM-7372](https://issues.apache.org/jira/browse/BEAM-7372)). * Drop support for Flink 1.10 ([BEAM-12281](https://issues.apache.org/jira/browse/BEAM-12281)). +* Custom implementations of `TriggerFn` now require that `may_lose_data` be implemented ([BEAM-9487](https://issues.apache.org/jira/browse/BEAM-9487)). Review comment: Ok, I removed `@abstractmethod` and gave a backwards-compatible default implementation. The note in CHANGES.md has been moved to the "New Features / Improvements" section, just so people know that the option exists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
