ibzib commented on a change in pull request #15105:
URL: https://github.com/apache/beam/pull/15105#discussion_r667152152
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -526,6 +534,14 @@ def _create_jar_packages(jar_packages, temp_dir):
return resources
+ @staticmethod
+ def _should_download_remote_extra_packages(package):
Review comment:
Yeah, I think it is better to make a small breaking change here, since
otherwise we are left with inconsistent behavior. We can document the change in
the release notes, and there is a fairly easy workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
