xinyuiscool commented on a change in pull request #15236:
URL: https://github.com/apache/beam/pull/15236#discussion_r680108811
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/SamzaPortablePipelineTranslator.java
##########
@@ -85,4 +91,23 @@ public static void createConfig(
}
}
}
+
+ public static Set<String> knownUrns() {
+ return TRANSLATORS.keySet();
+ }
+
+ /** Registers Samza translators. */
+ @AutoService(SamzaPortableTranslatorRegistrar.class)
Review comment:
Seems to me introducing another translator registrar just for portable
runner is not needed. The urns are the same, and the logic are already present
inside the current translators. Introducing another registrar is more
error-prune as the same translator has to be registered twice, in different
places. It's also easy to forget registering, as I think we already miss the
WindowAssign translation here. I wouldn't recommend having an extra registrar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
