reuvenlax commented on pull request #14974: URL: https://github.com/apache/beam/pull/14974#issuecomment-907485343
I can take a look again. On Fri, Aug 27, 2021 at 2:24 PM Kyle Weaver ***@***.***> wrote: > ***@***.**** approved this pull request. > > Thank you for writing tests! LGTM > ------------------------------ > > In > sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java > <https://github.com/apache/beam/pull/14974#discussion_r697723883>: > > > .withOptions(getFieldOptions(fieldDescriptor))); > + } else if (oneOfFieldLocationMap.containsKey(fieldDescriptorNumber)) { > + Field oneOfField = oneOfFieldLocationMap.get(fieldDescriptorNumber); > + if (oneOfField != null) { > > In that case, can we save a redundant check like this? > > Field oneOfField = oneOfFieldLocation.get(fieldDescriptorNumber); > if (oneOfField != null) { > fields.add(oneOfField); > } > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/14974#pullrequestreview-740899540>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVNKW6SN5I6XEIZSNVDT677CXANCNFSM46LBRHVA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
