scwhittle commented on a change in pull request #15355:
URL: https://github.com/apache/beam/pull/15355#discussion_r700143333
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
##########
@@ -467,15 +467,17 @@ SeekableByteChannel open(GcsPath path,
GoogleCloudStorageReadOptions readOptions
* @param type the type of object, eg "text/plain".
* @return a Callable object that encloses the operation.
*/
- public WritableByteChannel create(GcsPath path, String type) throws
IOException {
- return create(path, type, uploadBufferSizeBytes);
+ public WritableByteChannel create(GcsPath path, String type, boolean
expectFileToNotExist)
Review comment:
Don't merge, I think I need to change this so there is public api
stability.
I'll add a new flavor with an options class so we don't end up with more
down the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
