aromanenko-dev commented on pull request #14729: URL: https://github.com/apache/beam/pull/14729#issuecomment-914387065
I see your reasons but I still don't see why it can't be squashed into several atomic and independent commits that reflect every major change of this PR and can be rolled back independently if required? What kind of additional value the tiny commits can bring? Personally, taking into account that it was a long work on this feature and it required more changes than expected initially, I think it had to be split into several PRs or maybe even Jiras. In ideal world, every feature should have one Jira issue, one PR and one independent commit. If it requires more then it had to be split into more granular parts. Of course, there always can be some exceptions, but the goal is to keep a clear commit history and independent rollback. In our ["Commiter guide"](https://beam.apache.org/contribute/committer-guide/#pull-request-review-objectives) we have the requirements for granularity of changes that we discussed before and we have to follow. So my initial point was mostly about that that should help us to make a git history clear. Now I don't see that it's always a case but we can easily make it better. PS: Regarding the tools. I usually use `tig` for CLI and Intellij IDEA internal Git client to view annotated lines (`git blame`) or file history. Using lines annotations with many tiny commits signed by short commit messages and without Jira prefix makes it quite hard to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
