riteshghorse commented on a change in pull request #15430:
URL: https://github.com/apache/beam/pull/15430#discussion_r704467079
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -1061,12 +1061,11 @@ func makeTrigger(t window.Trigger) *pipepb.Trigger {
},
}
case window.AfterEndOfWindowTrigger:
- // TODO: change it to take user config triggers for early and
late firings
return &pipepb.Trigger{
Trigger: &pipepb.Trigger_AfterEndOfWindow_{
AfterEndOfWindow:
&pipepb.Trigger_AfterEndOfWindow{
- EarlyFirings:
makeTrigger(window.Trigger{Kind: window.ElementCountTrigger, ElementCount: 1}),
- LateFirings: nil,
+ EarlyFirings:
makeTrigger(*t.EarlyTrigger),
+ LateFirings:
makeTrigger(*t.LateTrigger),
Review comment:
Yes, thanks. I am initializing the EarlyTrigger with Default trigger. So
I would have to check not nil for LateTrigger. Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
