hlake21 commented on a change in pull request #15825:
URL: https://github.com/apache/beam/pull/15825#discussion_r741536325
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java
##########
@@ -232,7 +238,7 @@ private PendingJobData startWriteRename(
String bqLocation =
BigQueryHelpers.getDatasetLocation(datasetService, ref.getProjectId(),
ref.getDatasetId());
- String projectId = ref.getProjectId();
+ String projectId = loadJobProjectId == null ? ref.getProjectId() :
loadJobProjectId.get();
Review comment:
should we include the additional check here as well?
https://github.com/apache/beam/blob/92ba229336aa9cc4132f498d7049ecf67bc1c3b3/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java#L491
I wasn't sure if `ValueProvider<String>` accepts nulls as well.
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java
##########
@@ -232,7 +238,7 @@ private PendingJobData startWriteRename(
String bqLocation =
BigQueryHelpers.getDatasetLocation(datasetService, ref.getProjectId(),
ref.getDatasetId());
- String projectId = ref.getProjectId();
+ String projectId = loadJobProjectId == null ? ref.getProjectId() :
loadJobProjectId.get();
Review comment:
added!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
