TheNeuralBit commented on a change in pull request #16036:
URL: https://github.com/apache/beam/pull/16036#discussion_r758761039
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageArrowReader.java
##########
@@ -43,9 +42,7 @@
BigQueryStorageArrowReader(ReadSession readSession) throws IOException {
protoSchema = readSession.getArrowSchema();
InputStream input = protoSchema.getSerializedSchema().newInput();
- this.arrowBeamSchema =
- ArrowConversion.ArrowSchemaTranslator.toBeamSchema(
- ArrowConversion.arrowSchemaFromInput(input));
+
ArrowConversion.ArrowSchemaTranslator.toBeamSchema(ArrowConversion.arrowSchemaFromInput(input));
Review comment:
I worked with @MiguelAnzoWizeline on this. I think it really is dead
code, the other BigQueryStorageReader implementation doesn't verify it can be
converted to a Beam schema here:
https://github.com/apache/beam/blob/9160ba2dfb34ce4cdf1760c24b6e57fb912eb5c1/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageAvroReader.java#L40-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
