benWize commented on a change in pull request #16035:
URL: https://github.com/apache/beam/pull/16035#discussion_r760384882
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/AssignWindowsParDoFnFactory.java
##########
@@ -68,14 +68,12 @@ public ParDoFn create(
}
private static class AssignWindowsParDoFn<T, W extends BoundedWindow>
implements ParDoFn {
- private final DataflowExecutionContext.DataflowStepContext stepContext;
private final WindowFn<T, W> windowFn;
private @Nullable Receiver receiver;
AssignWindowsParDoFn(
WindowFn<T, W> windowFn, DataflowExecutionContext.DataflowStepContext
stepContext) {
Review comment:
Yes, I removed it
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/QueryablePipelineTest.java
##########
@@ -428,18 +428,5 @@ public void retainOnlyPrimitivesIgnoresUnreachableNodes() {
.apply(MapElements.into(TypeDescriptors.longs()).via(l -> l +
1));
}
});
-
- Components augmentedComponents =
- PipelineTranslation.toProto(p)
- .getComponents()
- .toBuilder()
- .putCoders("extra-coder", RunnerApi.Coder.getDefaultInstance())
- .putWindowingStrategies(
- "extra-windowing-strategy",
RunnerApi.WindowingStrategy.getDefaultInstance())
- .putEnvironments("extra-env",
RunnerApi.Environment.getDefaultInstance())
- .putPcollections("extra-pc",
RunnerApi.PCollection.getDefaultInstance())
- .build();
- Collection<String> primitiveComponents =
- QueryablePipeline.getPrimitiveTransformIds(augmentedComponents);
Review comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
