jrmccluskey commented on a change in pull request #16214: URL: https://github.com/apache/beam/pull/16214#discussion_r768781878
########## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process_test.go ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package expansionx + +import ( + "os" + "os/exec" + "strings" + "testing" +) + +func TestNewExpansionServiceRunner(t *testing.T) { + testPath := "path/to/jar" + serviceRunner := NewExpansionServiceRunner(testPath) + if serviceRunner.jarPath != testPath { + t.Errorf("JAR path mismatch: wanted %v, got %v", testPath, serviceRunner.jarPath) + } + commandString := strings.Join(serviceRunner.serviceCommand.Args, " ") + expCommandString := "java -jar " + testPath + " 8097" + if commandString != expCommandString { + t.Errorf("command mismatch: wanted %v, got %v", expCommandString, commandString) + } +} + +func TestStartService_badCommand(t *testing.T) { + serviceRunner := NewExpansionServiceRunner("") + serviceRunner.serviceCommand = exec.Command("jahva", "-jar") + err := serviceRunner.StartService() + if err == nil { + t.Error("StartService succeeded when it should have failed") + } +} + +func TestStartService_good(t *testing.T) { + testPath := "path/to/jar" + serviceRunner := NewExpansionServiceRunner(testPath) + serviceRunner.serviceCommand = exec.Command("which", "go") Review comment: I'm still getting used to considering interfaces as a way to enable mocking/dependency injection for testing. I agree that it seems like overkill for this class, but definitely a tool to keep in mind moving forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
