jrmccluskey commented on a change in pull request #16622:
URL: https://github.com/apache/beam/pull/16622#discussion_r794663757



##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflow.go
##########
@@ -59,6 +59,7 @@ var (
        numWorkers           = flag.Int64("num_workers", 0, "Number of workers 
(optional).")
        maxNumWorkers        = flag.Int64("max_num_workers", 0, "Maximum number 
of workers during scaling (optional).")
        diskSizeGb           = flag.Int64("disk_size_gb", 0, "Size of root disk 
for VMs, in GB (optional).")
+       diskType             = flag.String("disk_type", "", "Type of root disk 
for VMs (optional).")

Review comment:
       Would that just be adding a `--worker_disk_type` flag that stores its 
value in the `--disk_type` flag's variable? How would that interact when 
considering defaults?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to