VictorPlusC commented on a change in pull request #16601:
URL: https://github.com/apache/beam/pull/16601#discussion_r794851154
##########
File path: sdks/python/apache_beam/runners/interactive/utils_test.py
##########
@@ -327,5 +345,29 @@ def test_create_var_in_main(self):
self.assertIs(getattr(main_session, name, None), value)
+@patch(
+ 'apache_beam.io.gcp.internal.clients.storage.StorageV1',
+ return_value=MockStorageClient())
+class GCSUtilsTest(unittest.TestCase):
+ @patch(
+ 'apache_beam.io.gcp.internal.clients.storage.StorageBucketsGetRequest',
+ return_value='test-bucket-not-found')
+ def test_assert_bucket_exists_not_found(self, mock_client, mock):
+ with self.assertRaises(ValueError):
+ utils.assert_bucket_exists('')
+
+ @patch(
+ 'apache_beam.io.gcp.internal.clients.storage.StorageBucketsGetRequest',
+ return_value='test-bucket-not-verified')
Review comment:
Yes, I've included some additional code to check for the logger warning
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
