ihji commented on pull request #16490: URL: https://github.com/apache/beam/pull/16490#issuecomment-1029321024
> Looks pretty good. Left a few comments, but the main thing I'm wondering about this change is why Dataflow specifically needs this approach. Is this something we can generalize? Dataflow uses different artifact retrieval service implementation (worker built-in) and it currently only supports URL artifact types. > > If the other portable runners we expect people to use with Go (Flink, Spark, and Python Portable) are able to support URL artifacts then maybe we can instead do this check as part of the existing ResolveArtifactsWithConfig function. Yes. We can move this into `ResolveArtifactsWithConfig` after we confirm that URL artifact type is well supported by the artifact services used by other portable runners. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
