pabloem commented on a change in pull request #15549:
URL: https://github.com/apache/beam/pull/15549#discussion_r799898476



##########
File path: 
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -447,7 +388,7 @@ public void processElement(ProcessContext c) {
                         }
                       })
                   .withSideInputs(empty));
-      return materialized.apply(Reshuffle.viaRandomKey());
+      return materialized.apply(Distinct.create());

Review comment:
       @chamikaramj what are your thoughts on a parameter 
`withAllowDuplicates`? Or we could have the fewest possible knobs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to