tvalentyn commented on a change in pull request #16517:
URL: https://github.com/apache/beam/pull/16517#discussion_r800006634
##########
File path: sdks/python/apache_beam/transforms/ptransform.py
##########
@@ -1002,7 +1002,7 @@ def default_label(self):
return label_from_callable(self._fn)
-def ptransform_fn(fn):
+def ptransform_fn(fn) -> Callable[..., _PTransformFnPTransform]:
Review comment:
We currently use annotations with explicit `# type:` comment in
annotations. We added them back when still supporting Python 2, and planned a
rewrite into native Py3 type hints, but looks like that didn't land yet.
For consistency reasons, could you please you try the old style annotation
and see if that works for your purposes, @SandyChapman ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
