jrmccluskey commented on a change in pull request #16775:
URL: https://github.com/apache/beam/pull/16775#discussion_r802034197
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -418,7 +379,7 @@ func (m *marshaller) addMultiEdge(edge NamedEdge)
([]string, error) {
si[fmt.Sprintf("i%v", i)] = &pipepb.SideInput{
AccessPattern: &pipepb.FunctionSpec{
- Urn: URNMultimapSideInput,
+ Urn: URNIterableSideInput,
},
ViewFn: &pipepb.FunctionSpec{
Urn: "foo",
Review comment:
ViewFns are not currently implemented in the Go SDK but the proto
requires the field to be non-empty. So we put a dummy placeholder URN in place
for now. The WindowMappingFn field had the same set-up until I implemented the
basic window mapping functionality we use now.
"Required" fields in protos are a legacy thing that are discouraged/outright
unsupported now since they're a headache to deal with, generally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
