rainwoodman commented on pull request #16351: URL: https://github.com/apache/beam/pull/16351#issuecomment-1052768534
>> Can you help me better understand the behavior before your changes to default_type_hints() and _strip_output_annotations(), and then after the changes? It's been a while, and this is what I still remember. Before the change 1. output annotations (TaggedValue etc) are sometimes leaked to the default_type_hints, causing unintended type check errors when we were trying to rollout type propagation with GBK. 2. the output types are missing even if the python functions used to construct *Map*, CombinerFn have Python type annotations. After this change 1 and 2 are fixed. The input types are still missing in the Tuple Map variants as noted in the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
