mosche commented on a change in pull request #16987:
URL: https://github.com/apache/beam/pull/16987#discussion_r818809522
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystem.java
##########
@@ -548,12 +554,15 @@ CompleteMultipartUploadResponse multipartCopy(
Math.min(objectSize - 1, bytePosition +
uploadBufferSizeBytes - 1)))
Review comment:
Not sure, this might be another issue for multipart copies. Threshold to
use multipart copy vs atomic copy is 5GB, using the upload buffer size
(defaults to 5MB or 64MB depending on the environment) doesn't seem to make
sense, right? That generates far more parts than necessary. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
