ibzib commented on a change in pull request #17046:
URL: https://github.com/apache/beam/pull/17046#discussion_r827442561
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -36,7 +36,7 @@ import (
// TODO(lostluck): 2018/05/28 Extract these from their enum descriptors in the
pipeline_v1 proto
const (
URNImpulse = "beam:transform:impulse:v1"
- URNParDo = "beam:transform:pardo:v1"
+ URNParDo = "beam:transform:org.apache.beam:pardo:v1"
Review comment:
I don't think this is a correct URN. These URNs need to match the
definitions here:
https://github.com/apache/beam/blob/5ef9b7eb433e448b7f0fa37485623df0de6a8eef/model/pipeline/src/main/proto/beam_runner_api.proto#L224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
