thempatel commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1072885339
> > Why are we losing the license header on the generated GRPC pb.go files, but not the standard pb.go files? Not really an issue, since we can ignore it in the RAT check, but it is strange. > > TBH I don't know (sad). I saw that and spent some time loosely investigating. I agree that ideally we would have the license header, so I am happy to find some fix before merging! If you have tips on direction or if your google-foo is good, would love any help 🙏🏽 Ok so here's the diff: https://github.com/protocolbuffers/protobuf-go/blob/3992ea83a23c00882339f33511074d251e19822c/cmd/protoc-gen-go/internal_gengo/main.go#L73-L75 https://github.com/grpc/grpc-go/blob/f95b001a48df30dbbdb89ccb9a4781a242591651/cmd/protoc-gen-go-grpc/grpc.go#L89-L95 it's a difference in plugins, was the v1 grpc plugin used to generate the previous bindings or was the ASF manually added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
